This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Use REF1 for references to object #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
added a commit
to wilzbach/dlang.org
that referenced
this pull request
Feb 8, 2018
REF1 is currently only used once in entire DRuntime and Phobos, so maybe a special OBJECTREF macro would have been better? Anyhow, have a look at the only use of `REF1` to understand the motivation for this PR: https://dlang.org/phobos/std_file.html#.thisExePath Also there are three other PRs being blocked on this: - dlang/dmd#7342 - dlang/druntime#2082 - dlang/phobos#6140
ibuclaw
reviewed
Mar 11, 2018
changelog/core-memory-__delete.dd
Outdated
|
|
||
| Users should prefer $(REF destroy, object)` to explicitly finalize objects, | ||
| and only resort to $(REF __delete, core,memory) when $(REF destroy, object) | ||
| Users should prefer $(REF1 destroy, object)` to explicitly finalize objects, |
Member
There was a problem hiding this comment.
There's a dangling backtick here.
Contributor
Author
There was a problem hiding this comment.
Fixed (as the changelog file has been removed now.)
RazvanN7
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/dlang/dlang.org/blob/master/dlang.org.ddoc#L353
Argh...
See also: dlang/dlang.org#2191